Merge pull request #69 from Grasscutters/dev-fixes

Dev fixes

src/main/java/emu/grasscutter/server/packet/send/PacketScenePlayerLocationNotify.java

 package emu.grasscutter.server.packet.send;
 
 import emu.grasscutter.game.GenshinPlayer;
+import emu.grasscutter.game.GenshinScene;
 import emu.grasscutter.net.packet.GenshinPacket;
 import emu.grasscutter.net.packet.PacketOpcodes;
 import emu.grasscutter.net.proto.ScenePlayerLocationNotifyOuterClass.ScenePlayerLocationNotify;
 
 public class PacketScenePlayerLocationNotify extends GenshinPacket {
 	
-	public PacketScenePlayerLocationNotify(GenshinPlayer player) {
+	public PacketScenePlayerLocationNotify(GenshinScene scene) {
 		super(PacketOpcodes.ScenePlayerLocationNotify);
 		
 		ScenePlayerLocationNotify.Builder proto = ScenePlayerLocationNotify.newBuilder()
-				.setSceneId(player.getSceneId());
+				.setSceneId(scene.getId());
 		
-		for (GenshinPlayer p : player.getWorld().getPlayers()) {
+		for (GenshinPlayer p : scene.getPlayers()) {
 			proto.addPlayerLocList(p.getPlayerLocationInfo());
 		}
 		

src/main/java/emu/grasscutter/server/packet/send/PacketSceneTransToPointRsp.java

@@ -13,17 +13,6 @@ public class PacketSceneTransToPointRsp extends GenshinPacket {
 	public PacketSceneTransToPointRsp(GenshinPlayer player, int pointId, int sceneId) {
 		super(PacketOpcodes.SceneTransToPointRsp);
 
-		String code = sceneId + "_" + pointId;
-		ScenePointEntry scenePointEntry = GenshinData.getScenePointEntries().get(code);
-
-		float x = scenePointEntry.getPointData().getTranPos().getX();
-		float y = scenePointEntry.getPointData().getTranPos().getY();
-		float z = scenePointEntry.getPointData().getTranPos().getZ();
-
-		player.getPos().set(new Position(x, y, z));
-
-		player.getWorld().forceTransferPlayerToScene(player, sceneId, player.getPos());
-
 		SceneTransToPointRsp proto = SceneTransToPointRsp.newBuilder()
 				.setRetcode(0)
 	            .setPointId(pointId)
@@ -32,4 +21,14 @@ public class PacketSceneTransToPointRsp extends GenshinPacket {
 
 		this.setData(proto);
 	}
+
+	public PacketSceneTransToPointRsp() {
+		super(PacketOpcodes.SceneTransToPointRsp);
+		
+		SceneTransToPointRsp proto = SceneTransToPointRsp.newBuilder()
+				.setRetcode(1) // Internal server error
+	            .build();
+
+		this.setData(proto);
+	}
 }

src/main/java/emu/grasscutter/server/packet/send/PacketSceneUnlockInfoNotify.java

@@ -13,7 +13,7 @@ public class PacketSceneUnlockInfoNotify extends GenshinPacket {
 		SceneUnlockInfoNotify proto = SceneUnlockInfoNotify.newBuilder()
 				.addUnlockInfos(SceneUnlockInfo.newBuilder().setSceneId(1))
 				.addUnlockInfos(SceneUnlockInfo.newBuilder().setSceneId(3))
-				.addUnlockInfos(SceneUnlockInfo.newBuilder().setSceneId(4))
+				.addUnlockInfos(SceneUnlockInfo.newBuilder().setSceneId(4).addSceneTagIdList(106).addSceneTagIdList(109))
 				.addUnlockInfos(SceneUnlockInfo.newBuilder().setSceneId(5))
 				.addUnlockInfos(SceneUnlockInfo.newBuilder().setSceneId(6))
 				.addUnlockInfos(SceneUnlockInfo.newBuilder().setSceneId(7))

src/main/java/emu/grasscutter/server/packet/send/PacketWorldPlayerLocationNotify.java

@@ -14,7 +14,7 @@ public class PacketWorldPlayerLocationNotify extends GenshinPacket {
 		WorldPlayerLocationNotify.Builder proto = WorldPlayerLocationNotify.newBuilder();
 		
 		for (GenshinPlayer p : world.getPlayers()) {
-			proto.addPlayerLocList(p.getPlayerLocationInfo());
+			proto.addPlayerLocList(p.getWorldPlayerLocationInfo());
 		}
 		
 		this.setData(proto);