From 701812aa8f03b1caeaa318bb625a40cecd2a478b Mon Sep 17 00:00:00 2001 From: Hesper Yin Date: Sun, 30 Aug 2020 20:41:28 -0400 Subject: [PATCH] Update camera_rays.md --- docs/pathtracer/camera_rays.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/pathtracer/camera_rays.md b/docs/pathtracer/camera_rays.md index c1fafaf..2a65735 100644 --- a/docs/pathtracer/camera_rays.md +++ b/docs/pathtracer/camera_rays.md @@ -27,8 +27,8 @@ Once you have implemented `Pathtracer::trace_pixel`, `Rect::Uniform::sample` and **Tips:** * Since it'll be hard to know if you camera rays are correct until you implement primitive intersection, we recommend debugging your camera rays by checking what your implementation of `Camera::generate_ray` does with rays at the center of the screen (0.5, 0.5) and at the corners of the image. -* The code can log the results of raytracing for visualization and debugging. To do so, simply call function `Pathtracer::log_ray` in your `Pathtracer::trace_pixel`. Function `Pathtracer::log_ray` takes in 3 arguments: the ray thay you want to log, a float that specifies the time/distance to log that ray up to, as well as the color. You don't need to worry about the color as it is being set by default. -After running the ray tracer, rays will be shown as lines in visualizer. Press v to switch to the visualizer, and use s to toggle showing rays. A yellow ray indicates that it intersected some primitive (which you will implement soon). Be sure to wait for rendering to complete so you see all rays while visualizing, a message is printed to standard output on completion. **Ray logging is NOT thread-safe, so only use with a single thread (the default -t 1 setting) and remember to disable it out when you render using multiple threads**. +* The code can log the results of raytracing for visualization and debugging. To do so, simply call function `Pathtracer::log_ray` in your `Pathtracer::trace_pixel`. Function `Pathtracer::log_ray` takes in 3 arguments: the ray thay you want to log, a float that specifies the time/distance to log that ray up to, as well as the color. You don't need to worry about the color as it is being set to white by default. +After running the ray tracer, rays will be shown as lines in visualizer. Press v to switch to the visualizer, and use s to toggle showing rays. A yellow ray indicates that it intersected some primitive (which you will implement soon). Be sure to wait for rendering to complete so you see all rays while visualizing, a message is printed to standard output on completion. **Extra credit ideas:** @@ -39,4 +39,4 @@ After running the ray tracer, rays will be shown as lines in visualizer. Press v * N-Rooks (Latin Hypercube) sampling * Sobol sequence sampling * Halton sequence sampling - * Hammersley sequence sampling \ No newline at end of file + * Hammersley sequence sampling -- GitLab